[Fix] node consistency and log sync error #66
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix node consistency issues when selecting EVM endpoints and suppress spurious log sync errors during application shutdown.
Key Changes:
- Modified endpoint selection logic to prefer the currently selected endpoint when block heights are equal
- Added
syscall.EINVALto the list of ignored errors during log sync operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| relayer/chains/evm/client.go | Updates endpoint selection logic to maintain consistency by preferring the currently selected endpoint when multiple endpoints have equal block heights |
| cmd/root.go | Extends error handling in log sync to ignore EINVAL errors in addition to ENOTTY errors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Fixed: node consistency and log sync error
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)